[PATCH 1/5] d3dx9: Turn D3DXCreateEffectEx FIXME into a TRACE, improve it a bit.

Matteo Bruni mbruni at codeweavers.com
Mon Mar 3 09:28:09 CST 2014


---
 dlls/d3dx9_36/effect.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
index a4325af..0ec17c1 100644
--- a/dlls/d3dx9_36/effect.c
+++ b/dlls/d3dx9_36/effect.c
@@ -5294,8 +5294,10 @@ HRESULT WINAPI D3DXCreateEffectEx(struct IDirect3DDevice9 *device, const void *s
     struct ID3DXEffectImpl *object;
     HRESULT hr;
 
-    FIXME("(%p, %p, %u, %p, %p, %p, %#x, %p, %p, %p): semi-stub\n", device, srcdata, srcdatalen, defines, include,
-        skip_constants, flags, pool, effect, compilation_errors);
+    TRACE("device %p, srcdata %p, srcdatalen %u, defines %p, include %p,\n",
+            device, srcdata, srcdatalen, defines, include);
+    TRACE("skip_constants %p, flags %#x, pool %p, effect %p, compilation_errors %p.\n",
+            skip_constants, flags, pool, effect, compilation_errors);
 
     if (compilation_errors)
         *compilation_errors = NULL;
@@ -5310,6 +5312,9 @@ HRESULT WINAPI D3DXCreateEffectEx(struct IDirect3DDevice9 *device, const void *s
     if (!effect)
         return D3D_OK;
 
+    if (skip_constants)
+        FIXME("skip_constants is not NULL, not supported yet.\n");
+
     object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object));
     if (!object)
         return E_OUTOFMEMORY;
-- 
1.8.3.2




More information about the wine-patches mailing list