[PATCH] hhctrl.ocx: free the correct buffer (Coverity)

Marcus Meissner marcus at jet.franken.de
Sat Mar 8 03:00:53 CST 2014


The next_node() function should not free the buffer,
the caller will do that, or not.

1191507 Double free
---
 dlls/hhctrl.ocx/stream.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/hhctrl.ocx/stream.c b/dlls/hhctrl.ocx/stream.c
index 4dc9645..6e831e5 100644
--- a/dlls/hhctrl.ocx/stream.c
+++ b/dlls/hhctrl.ocx/stream.c
@@ -145,7 +145,7 @@ BOOL next_node(stream_t *stream, strbuf_t *buf)
     strbuf_init(&tmpbuf);
     if(!find_node_end(stream, &tmpbuf))
     {
-        strbuf_free(buf);
+        strbuf_free(&tmpbuf);
         return FALSE;
     }
     strbuf_free(&tmpbuf);
-- 
1.8.4.5




More information about the wine-patches mailing list