[PATCH] ver.dll16: filelen is an in/out parameter (Coverity)

Marcus Meissner marcus at jet.franken.de
Sun May 4 05:52:31 CDT 2014


701745 Uninitialized scalar variable

cross checked with MSDN, the filelenptr is a in/out variable.
---
 dlls/ver.dll16/version.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/ver.dll16/version.c b/dlls/ver.dll16/version.c
index 5abe1c4..b2cb9ae 100644
--- a/dlls/ver.dll16/version.c
+++ b/dlls/ver.dll16/version.c
@@ -522,7 +522,8 @@ DWORD WINAPI VerInstallFile16( UINT16 flags,
                                LPSTR lpszSrcDir, LPSTR lpszDestDir, LPSTR lpszCurDir,
                                LPSTR lpszTmpFile, UINT16 *lpwTmpFileLen )
 {
-    UINT filelen;
+    UINT filelen = *lpwTmpFileLen;
+
     DWORD retv = VerInstallFileA( flags, lpszSrcFilename, lpszDestFilename,
                                     lpszSrcDir, lpszDestDir, lpszCurDir,
                                     lpszTmpFile, &filelen);
-- 
1.8.4.5




More information about the wine-patches mailing list