[PATCH] advapi32: removed a incorrect LocalFree (Coverity)

Marcus Meissner marcus at jet.franken.de
Sun May 4 05:59:40 CDT 2014


Hi,

please ignore this patch, it is incorrect.

pGetSecurityInfo() some lines above allocates a new pSD, 
Coverity and me did not see that.

Ciao, Marcus
On Sun, May 04, 2014 at 12:56:28PM +0200, Marcus Meissner wrote:
> 744958 Free of array-typed value
> 
> pSD is not allocated, but pointed to a stack variable.
> ---
>  dlls/advapi32/tests/security.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c
> index a0574c4..345d606 100644
> --- a/dlls/advapi32/tests/security.c
> +++ b/dlls/advapi32/tests/security.c
> @@ -3980,7 +3980,6 @@ static void test_GetSecurityInfo(void)
>          ok(ace->Mask == 0x1f01ff, "Administators Group ACE has unexpected mask (0x%x != 0x1f01ff)\n",
>                                    ace->Mask);
>      }
> -    LocalFree(pSD);
>      CloseHandle(obj);
>  }
>  
> -- 
> 1.8.4.5
> 
> 
> 
> 



More information about the wine-patches mailing list