testbot/CheckWinetestUpdate: Let the Engine handle moving staging files to the jobs directory.

Francois Gouget fgouget at codeweavers.com
Thu May 15 08:51:04 CDT 2014

Otherwise there is a race condition between CheckWinetestUpdate and the Engine.

Step::HandleStaging() is also called by ScheduleJobs() which is called 
on a regular basis by the SafetyNet() callback among others. So if 
ScheduleJobs() and CheckWinetestUpdate call HandleStaging() at the same 
time they could both be trying to move the staging file to the job's 
directory at the same time and the one losing the race would report 
spurious errors.

 testbot/bin/CheckForWinetestUpdate.pl | 2 --
 1 file changed, 2 deletions(-)

diff --git a/testbot/bin/CheckForWinetestUpdate.pl b/testbot/bin/CheckForWinetestUpdate.pl
index 98165a3..fc24fb6 100755
--- a/testbot/bin/CheckForWinetestUpdate.pl
+++ b/testbot/bin/CheckForWinetestUpdate.pl
@@ -110,8 +110,6 @@ sub AddJob
       LogMsg "Failed to save job: $ErrMessage\n";
       exit 1;
-    $NewStep->HandleStaging($NewJob->Id);

More information about the wine-patches mailing list