user32/tests: Ensure ShowWindow returns false when window is already hidden
Bruno Jesus
00cpxxx at gmail.com
Mon Nov 24 19:54:45 CST 2014
A recent change in the code turned a ShowWindow(SW_HIDE) in an already
hidden window a no-op, but the return code was not tested.
Many tests failed in my attempt to run but not related to my changes:
https://testbot.winehq.org/JobDetails.pl?Key=10432
-------------- next part --------------
diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index 28bb35e..778b3cf 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -4626,7 +4626,7 @@ static DWORD CALLBACK show_window_thread(LPVOID arg)
HWND hwnd = arg;
/* function will not return if ShowWindow(SW_HIDE) calls SendMessage() */
- ShowWindow(hwnd, SW_HIDE);
+ ok(ShowWindow(hwnd, SW_HIDE) == FALSE, "ShowWindow(SW_HIDE) expected FALSE\n");
return 0;
}
@@ -4669,7 +4669,7 @@ static void test_messages(void)
ok_sequence(WmHideOverlappedSeq, "ShowWindow(SW_HIDE):overlapped", FALSE);
/* test ShowWindow(SW_HIDE) on a hidden window - single threaded */
- ShowWindow(hwnd, SW_HIDE);
+ ok(ShowWindow(hwnd, SW_HIDE) == FALSE, "ShowWindow(SW_HIDE) expected FALSE\n");
flush_events();
ok_sequence(WmEmptySeq, "ShowWindow(SW_HIDE):overlapped", FALSE);
More information about the wine-patches
mailing list