mciavi32: Initialize a variable (Cppcheck)

Bruno Jesus 00cpxxx at gmail.com
Fri Oct 31 20:44:23 CDT 2014


[dlls\mciavi32\info.c:184]: (error) Uninitialized variable: ret

ret may be returned with garbage, initialize with default case value to solve.
-------------- next part --------------
diff --git a/dlls/mciavi32/info.c b/dlls/mciavi32/info.c
index 668464c..f679778 100644
--- a/dlls/mciavi32/info.c
+++ b/dlls/mciavi32/info.c
@@ -74,7 +74,7 @@ DWORD 	MCIAVI_ConvertTimeFormatToFrame(WINE_MCIAVI* wma, DWORD val)
 DWORD	MCIAVI_mciGetDevCaps(UINT wDevID, DWORD dwFlags,  LPMCI_GETDEVCAPS_PARMS lpParms)
 {
     WINE_MCIAVI*	wma = MCIAVI_mciGetOpenDev(wDevID);
-    DWORD		ret;
+    DWORD		ret = MCIERR_UNSUPPORTED_FUNCTION;
 
     TRACE("(%04x, %08X, %p)\n", wDevID, dwFlags, lpParms);
 
@@ -175,7 +175,6 @@ DWORD	MCIAVI_mciGetDevCaps(UINT wDevID, DWORD dwFlags,  LPMCI_GETDEVCAPS_PARMS l
 	/* w2k does not know MAX_WINDOWS or MAX/MINIMUM_RATE */
 	default:
             FIXME("Unknown capability (%08x) !\n", lpParms->dwItem);
-            ret = MCIERR_UNSUPPORTED_FUNCTION;
             break;
 	}
     }


More information about the wine-patches mailing list