comdlg32: Avoid a compiler warning with newer clang or GCC. (RESEND)

Gerald Pfeifer gerald at pfeifer.com
Sun Sep 7 06:26:47 CDT 2014


Is I noted in my previous mail, current snapshots of GCC now do 
warn here even with just -Wall.

Gerald
---
 dlls/comdlg32/tests/finddlg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/comdlg32/tests/finddlg.c b/dlls/comdlg32/tests/finddlg.c
index be98308..79fc67d 100644
--- a/dlls/comdlg32/tests/finddlg.c
+++ b/dlls/comdlg32/tests/finddlg.c
@@ -54,7 +54,7 @@ static void test_param_check(void)
 #define CHECK_FIND_OR_REPLACE(FUNC, FAIL, ERR_CODE) \
     do { \
        HWND hwnd = FUNC(pFr); \
-       BOOL is_ok = !!hwnd == !FAIL; \
+       BOOL is_ok = (!!hwnd) == !FAIL; \
        ok(is_ok, "%s should%s fail\n", #FUNC, FAIL ? "" : "n't"); \
        if (FAIL && is_ok) { \
           DWORD ext_err = CommDlgExtendedError(); \
-- 
1.9.3



More information about the wine-patches mailing list