[PATCH] dwrite: avoid NULL ptr dereference (Coverity)

Marcus Meissner marcus at jet.franken.de
Sun Sep 21 07:26:13 CDT 2014


1232718 Dereference after null check

If one of them would be NULL, we would crash here, free_layout_range
is supposed to handle NULL ptrs

    if (!right || !cur) {
CID 1232718 (#1 of 1): Dereference after null check (FORWARD_NULL)8. var_deref_model: Passing null pointer right to free_layout_range, which dereferences it. [show details]
           free_layout_range(right);
CID 1232717: Dereference after null check (FORWARD_NULL) [select issue]
           free_layout_range(cur);
           return E_OUTOFMEMORY;
---
 dlls/dwrite/layout.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/dwrite/layout.c b/dlls/dwrite/layout.c
index 0b33b92..f6b1e8c 100644
--- a/dlls/dwrite/layout.c
+++ b/dlls/dwrite/layout.c
@@ -271,6 +271,8 @@ static struct layout_range *alloc_layout_range_from(struct layout_range *from, c
 
 static void free_layout_range(struct layout_range *range)
 {
+    if (!range)
+        return;
     if (range->object)
         IDWriteInlineObject_Release(range->object);
     if (range->effect)
-- 
1.8.4.5




More information about the wine-patches mailing list