[PATCH] ntdll: potential buffer overwrite (Coverity)

Marcus Meissner marcus at jet.franken.de
Sun Apr 19 04:59:22 CDT 2015


1225853 Unused value
1225854 Unused value

(Coverity saw basically overwriting status ... the code was missing
 the else construct the other cases have already.)
---
 dlls/ntdll/cdrom.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c
index 34910e7..25a3fde 100644
--- a/dlls/ntdll/cdrom.c
+++ b/dlls/ntdll/cdrom.c
@@ -3090,8 +3090,11 @@ NTSTATUS CDROM_DeviceIoControl(HANDLE hDevice,
         sz = sizeof(DVD_REGION);
         if (lpInBuffer != NULL || nInBufferSize != 0) status = STATUS_INVALID_PARAMETER;
         else if (nOutBufferSize < sz) status = STATUS_BUFFER_TOO_SMALL;
-        TRACE("doing DVD_Get_REGION\n");
-        status = DVD_GetRegion(fd, lpOutBuffer);
+        else
+        {
+            TRACE("doing DVD_Get_REGION\n");
+            status = DVD_GetRegion(fd, lpOutBuffer);
+        }
         break;
     case IOCTL_DVD_READ_STRUCTURE:
         sz = sizeof(DVD_LAYER_DESCRIPTOR);
-- 
1.8.4.5




More information about the wine-patches mailing list