[PATCH 2/4 v2] dsound/tests: Test Pan for 3D secondary buffers too.

Andrew Eikum aeikum at codeweavers.com
Wed Dec 2 08:38:54 CST 2015


Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>

On Tue, Dec 01, 2015 at 02:48:43PM +0100, Michael Stefaniuc wrote:
> Signed-off-by: Michael Stefaniuc <mstefani at redhat.de>
> ---
> Grrrr... got confused by the has_3d and has_3dbuffer. That's something
> for the braves to clean up.
> 
> 
>  dlls/dsound/tests/ds3d.c  |  9 +++++++++
>  dlls/dsound/tests/ds3d8.c | 10 ++++++++++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/dlls/dsound/tests/ds3d.c b/dlls/dsound/tests/ds3d.c
> index 0e0d26f..1a019dd 100644
> --- a/dlls/dsound/tests/ds3d.c
> +++ b/dlls/dsound/tests/ds3d.c
> @@ -886,7 +886,16 @@ static HRESULT test_secondary(LPGUID lpGuid, int play,
>                  ok(rc==DS_OK,"IDirectSoundBuffer_SetVolume(secondary) failed: %08x\n",rc);
>                  rc=IDirectSoundBuffer_SetPan(secondary,0);
>                  ok(rc==DS_OK,"IDirectSoundBuffer_SetPan(secondary) failed: %08x\n",rc);
> +            } else if (has_3dbuffer) {
> +                LONG pan;
> +
> +                rc=IDirectSoundBuffer_GetPan(secondary,&pan);
> +                ok(rc==DS_OK,"IDirectSoundBuffer_GetPan() failed, returned: %08x\n", rc);
> +                rc=IDirectSoundBuffer_SetPan(secondary,0);
> +                todo_wine
> +                ok(rc==DS_OK,"IDirectSoundBuffer_SetPan() failed, returned: %08x\n", rc);
>              }
> +
>              if (has_duplicate) {
>                  LPDIRECTSOUNDBUFFER duplicated=NULL;
>  
> diff --git a/dlls/dsound/tests/ds3d8.c b/dlls/dsound/tests/ds3d8.c
> index b18a91f..330f590 100644
> --- a/dlls/dsound/tests/ds3d8.c
> +++ b/dlls/dsound/tests/ds3d8.c
> @@ -730,7 +730,17 @@ static HRESULT test_secondary8(LPGUID lpGuid, BOOL play,
>                  ok(rc==DS_OK,"IDirectSoundBuffer_SetVolume(secondary) failed: %08x\n",rc);
>                  rc=IDirectSoundBuffer_SetPan(secondary,0);
>                  ok(rc==DS_OK,"IDirectSoundBuffer_SetPan(secondary) failed: %08x\n",rc);
> +            } else {
> +                LONG pan;
> +
> +                rc=IDirectSoundBuffer_GetPan(secondary,&pan);
> +                ok(rc==DSERR_CONTROLUNAVAIL,"IDirectSoundBuffer_GetPan() "
> +                   "should have returned DSERR_CONTROLUNAVAIL, returned: %08x\n", rc);
> +                rc=IDirectSoundBuffer_SetPan(secondary,0);
> +                ok(rc==DSERR_CONTROLUNAVAIL,"IDirectSoundBuffer_SetPan() "
> +                   "should have returned DSERR_CONTROLUNAVAIL, returned: %08x\n", rc);
>              }
> +
>              if (has_duplicate) {
>                  LPDIRECTSOUNDBUFFER duplicated=NULL;
>  
> -- 
> 2.1.0
> 
> 



More information about the wine-patches mailing list