services: Fix access adjustment by reordering code (Clang)

André Hentschel nerv at dawncrow.de
Tue Dec 22 12:29:16 CST 2015


Signed-off-by: André Hentschel <nerv at dawncrow.de>
---
 programs/services/rpc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/programs/services/rpc.c b/programs/services/rpc.c
index 89a8c91..dd44965 100644
--- a/programs/services/rpc.c
+++ b/programs/services/rpc.c
@@ -352,12 +352,13 @@ static DWORD create_handle_for_service(struct service_entry *entry, DWORD dwDesi
         return ERROR_NOT_ENOUGH_SERVER_MEMORY;
     }
 
+    if (dwDesiredAccess & MAXIMUM_ALLOWED)
+        dwDesiredAccess |= SERVICE_ALL_ACCESS;
+
     service->hdr.type = SC_HTYPE_SERVICE;
     service->hdr.access = dwDesiredAccess;
     RtlMapGenericMask(&service->hdr.access, &g_svc_generic);
     service->service_entry = entry;
-    if (dwDesiredAccess & MAXIMUM_ALLOWED)
-        dwDesiredAccess |= SERVICE_ALL_ACCESS;
 
     *phService = &service->hdr;
     return ERROR_SUCCESS;
-- 
1.9.1





More information about the wine-patches mailing list