mmdevapi: Skip device if GetId fails (Coverity) (try 2)
Andrew Eikum
aeikum at codeweavers.com
Wed Dec 23 08:53:34 CST 2015
Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
On Tue, Dec 22, 2015 at 11:18:46PM +0100, André Hentschel wrote:
> Signed-off-by: André Hentschel <nerv at dawncrow.de>
> ---
> CID 752979
>
> dlls/mmdevapi/devenum.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c
> index d50d206..e63a199 100644
> --- a/dlls/mmdevapi/devenum.c
> +++ b/dlls/mmdevapi/devenum.c
> @@ -1065,9 +1065,15 @@ static HRESULT WINAPI MMDevEnum_GetDevice(IMMDeviceEnumerator *iface, const WCHA
>
> for (i = 0; i < MMDevice_count; ++i)
> {
> + HRESULT hr;
> WCHAR *str;
> dev = &MMDevice_head[i]->IMMDevice_iface;
> - IMMDevice_GetId(dev, &str);
> + hr = IMMDevice_GetId(dev, &str);
> + if (FAILED(hr))
> + {
> + WARN("GetId failed: %08x\n", hr);
> + continue;
> + }
>
> if (str && !lstrcmpW(str, name))
> {
> --
> 1.9.1
>
>
>
>
More information about the wine-patches
mailing list