msi: Use the intended attributes when overwriting the target file in cabinet_copy_file.

Thomas Faber thomas.faber at reactos.org
Sun Dec 27 06:01:50 CST 2015


Resending deferred.

On 2015-11-23 14:13, Thomas Faber wrote:
> The current code uses the old file's attributes, which means it would
> make the file read-only again. This would e.g. prevent the deletion of
> the file at the end of test_readonlyfile_cab (and should probably even
> make this CreateFileW call fail since it specifies GENERIC_WRITE).
> 
> The reason this currently works in Wine is that CreateFile keeps the
> existing file attributes in this case (see the todo_wine in
> test_NtCreateFile).
> 
> The patch fixes msi to use the correct attributes as returned by the
> callback.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-msi-Use-the-intended-attributes-when-overwriting-the.patch
Type: text/x-diff
Size: 1092 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20151227/aa5adf8f/attachment.patch>


More information about the wine-patches mailing list