quartz: Don't cache IFilterMapper2 interface in FilterGraph2.

Thomas Faber thomas.faber at reactos.org
Sun Dec 27 06:04:16 CST 2015


Final patch of the series was deferred.

On 2015-11-20 15:57, Thomas Faber wrote:
> As shown by MPC-HC and tests, the constructor must not take a reference
> to outer_unk. Instead, acquire the IFilterMapper2 interface as needed
> later.


On 2015-11-20 15:51, Thomas Faber wrote:
> MPC-HC v1.7.10's CFGManager class creates a filter graph object during
> its constructor, which means it passes in an outer object with a zero
> reference count. Wine does an AddRef/Release on this object when
> constructing the filter graph, thus its reference count drops back
> to 0 and the CFGManager object gets freed prematurely.
>
> The rest of this series adds tests showing that the outer object does
> not get referenced (even temporarily) during construction, and then
> fixes Wine's implementation to comply with that requirement.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-quartz-Don-t-cache-IFilterMapper2-interface-in-Filte.patch
Type: text/x-diff
Size: 6907 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20151227/fd58cbbd/attachment-0001.patch>


More information about the wine-patches mailing list