setupapi: Implement SetupOpenLog(), SetupLogErrorA(), SetupLogErrorW(), SetupCloseLog() (try 3)

Pierre Schweitzer pierre at reactos.org
Sun Feb 8 05:47:35 CST 2015


Dear all,

Please find attached a patch that implements the functions
SetupOpenLog(), SetupLogErrorA(), SetupLogErrorW() and SetupCloseLog()
in setupapi.dll. It comes with a few tests to highlight corners cases
(and errors) of the functions.
This was designed and tested on Windows 2003 server (even though it's
been available starting Windows 2000).
It also has been tested on W7, where a little different in behavior
happens (as shown in tests). It doesn't accept NULL parameter anymore.

Also, there are some behavior I implemented that I failed at designing a
test for: (null) on NULL string, written to setupact.log whatever the
severity level even if wrong. If anyone has ideas about how to do it
properly, just shoot.

Here, with such an implementation, the 11 tests are passing.

This is the third try, taking into account the comments from
wine-devel, and the Marvin fails.

With my best regards,
-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-setupapi-Implement-SetupOpenLog-SetupLogErrorA-Setup.patch
Type: text/x-patch
Size: 12062 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20150208/97826680/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3940 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20150208/97826680/attachment-0001.bin>


More information about the wine-patches mailing list