ole32: Remove an always true conditional subexpression (PVS-Studio)

Michael Stefaniuc mstefani at redhat.de
Tue Feb 17 17:09:03 CST 2015


---
 dlls/ole32/storage32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ole32/storage32.c b/dlls/ole32/storage32.c
index 26fc0d8..5e434e0 100644
--- a/dlls/ole32/storage32.c
+++ b/dlls/ole32/storage32.c
@@ -2969,7 +2969,7 @@ static HRESULT StorageImpl_GrabLocks(StorageImpl *This, DWORD openFlags)
     hr = S_OK;
 
     /* First check for any conflicting locks. */
-    if (SUCCEEDED(hr) && (openFlags & STGM_PRIORITY) == STGM_PRIORITY)
+    if ((openFlags & STGM_PRIORITY) == STGM_PRIORITY)
         hr = StorageImpl_CheckLockRange(This, RANGELOCK_COMMIT, RANGELOCK_COMMIT, STG_E_LOCKVIOLATION);
 
     if (SUCCEEDED(hr) && (STGM_ACCESS_MODE(openFlags) != STGM_WRITE))
-- 
1.9.3



More information about the wine-patches mailing list