quartz: Remove an always true conditional subexpression (PVS-Studio)

Michael Stefaniuc mstefani at redhat.de
Tue Feb 17 17:11:40 CST 2015


---
 dlls/quartz/pin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/quartz/pin.c b/dlls/quartz/pin.c
index 78b6fa2..8377be5 100644
--- a/dlls/quartz/pin.c
+++ b/dlls/quartz/pin.c
@@ -268,7 +268,7 @@ HRESULT WINAPI PullPin_ReceiveConnection(IPin * iface, IPin * pReceivePin, const
         props.cbAlign = 1;
         props.cbPrefix = 0;
 
-        if (SUCCEEDED(hr) && (This->fnQueryAccept(This->pUserData, pmt) != S_OK))
+        if (This->fnQueryAccept(This->pUserData, pmt) != S_OK)
             hr = VFW_E_TYPE_NOT_ACCEPTED; /* FIXME: shouldn't we just map common errors onto 
                                            * VFW_E_TYPE_NOT_ACCEPTED and pass the value on otherwise? */
 
-- 
1.9.3



More information about the wine-patches mailing list