[PATCH 2/5] qcap: Remove initialization code from QI of VfwCapture.

Michael Stefaniuc mstefani at redhat.de
Mon Jul 27 02:26:56 CDT 2015


---
a.) IBaseFilter_EnumPins() in native has no IPins without initialization.
b.) No match for "Capture system not initialised when looking for" in
    either google or bugzilla.
c.) Another attempt on getting me on "The Wall of Fame" ;)



 dlls/qcap/vfwcapture.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/dlls/qcap/vfwcapture.c b/dlls/qcap/vfwcapture.c
index 7804a3d..67cc8f5 100644
--- a/dlls/qcap/vfwcapture.c
+++ b/dlls/qcap/vfwcapture.c
@@ -181,22 +181,6 @@ static HRESULT WINAPI VfwCapture_QueryInterface(IBaseFilter * iface, REFIID riid
     else if (IsEqualIID(riid, &IID_IPersistPropertyBag))
         *ppv = &This->IPersistPropertyBag_iface;
 
-    if (!IsEqualIID(riid, &IID_IUnknown) &&
-        !IsEqualIID(riid, &IID_IPersist) &&
-        !IsEqualIID(riid, &IID_IPersistPropertyBag) &&
-        !This->init)
-    {
-        FIXME("Capture system not initialised when looking for %s, "
-              "trying it on primary device now\n", debugstr_guid(riid));
-        This->driver_info = qcap_driver_init( This->pOutputPin, 0 );
-        if (!This->driver_info)
-        {
-            ERR("VfwCapture initialisation failed\n");
-            return E_UNEXPECTED;
-        }
-        This->init = TRUE;
-    }
-
     if (*ppv)
     {
         TRACE("Returning %s interface\n", debugstr_guid(riid));
-- 
2.1.0



More information about the wine-patches mailing list