gdiplus: Check GetMetadataFormat() return value (Coverity)
Nikolay Sivov
nsivov at codeweavers.com
Sat Jun 27 06:30:35 CDT 2015
---
-------------- next part --------------
From 978ff3a5df29561c08360cfc12cccfc4cde581ff Mon Sep 17 00:00:00 2001
From: Nikolay Sivov <nsivov at codeweavers.com>
Date: Sat, 27 Jun 2015 14:29:37 +0300
Subject: [PATCH] gdiplus: Check GetMetadataFormat() return value (Coverity)
---
dlls/gdiplus/image.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c
index 351c5b3..73f2f74 100644
--- a/dlls/gdiplus/image.c
+++ b/dlls/gdiplus/image.c
@@ -3058,8 +3058,8 @@ static BOOL get_bool_property(IWICMetadataReader *reader, const GUID *guid, cons
PROPVARIANT id, value;
BOOL ret = FALSE;
- IWICMetadataReader_GetMetadataFormat(reader, &format);
- if (!IsEqualGUID(&format, guid)) return FALSE;
+ hr = IWICMetadataReader_GetMetadataFormat(reader, &format);
+ if (FAILED(hr) || !IsEqualGUID(&format, guid)) return FALSE;
PropVariantInit(&id);
PropVariantInit(&value);
@@ -3085,8 +3085,8 @@ static PropertyItem *get_property(IWICMetadataReader *reader, const GUID *guid,
PROPVARIANT id, value;
PropertyItem *item = NULL;
- IWICMetadataReader_GetMetadataFormat(reader, &format);
- if (!IsEqualGUID(&format, guid)) return NULL;
+ hr = IWICMetadataReader_GetMetadataFormat(reader, &format);
+ if (FAILED(hr) || !IsEqualGUID(&format, guid)) return NULL;
PropVariantInit(&id);
PropVariantInit(&value);
--
2.1.4
More information about the wine-patches
mailing list