winecfg: Fix string buffer length for override settings (Valgrind)

Nikolay Sivov nsivov at codeweavers.com
Sat Jun 27 15:23:38 CDT 2015


Accidentally spotted this when running with heap warnings enabled, later 
valgrind confirmed issue location.
-------------- next part --------------
From 674cceb4fbd5ab1c0e12fa54b400882c032f0898 Mon Sep 17 00:00:00 2001
From: Nikolay Sivov <nsivov at codeweavers.com>
Date: Sat, 27 Jun 2015 23:19:56 +0300
Subject: [PATCH] winecfg: Fix string buffer length for override settings
 (Valgrind)

---
 programs/winecfg/libraries.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/winecfg/libraries.c b/programs/winecfg/libraries.c
index f00449d..ff3f67a 100644
--- a/programs/winecfg/libraries.c
+++ b/programs/winecfg/libraries.c
@@ -106,7 +106,7 @@ static enum dllmode string_to_mode(char *in)
     enum dllmode res;
 
     len = strlen(in);
-    out = HeapAlloc(GetProcessHeap(), 0, len);
+    out = HeapAlloc(GetProcessHeap(), 0, len + 1);
 
     /* remove the spaces */
     for (i = j = 0; i <= len; ++i) {
-- 
2.1.4



More information about the wine-patches mailing list