winedbg: Add be_xpoint_FAIL=-1 to enum be_xpoint_type.
Gerald Pfeifer
gerald at pfeifer.com
Mon Jun 29 18:12:02 CDT 2015
This replaces my original submission with a different approach.
Recall this is about clang 3.4.1 complaining as follows:
gdbproxy.c:2147:23: warning: comparison of constant -1 with
expression of type 'enum be_xpoint_type' is always false
In my original submission I noted that "I see two ways to address this:
adding a dummy set to -1 to the enum, or casting the enum to int before
comparing against -1".
Michael kindly provided feeback to go with the former approach.
This patch does that. (Thanks, Michael!)
Gerald
---
programs/winedbg/be_cpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/programs/winedbg/be_cpu.h b/programs/winedbg/be_cpu.h
index 889f638..c95ed7c 100644
--- a/programs/winedbg/be_cpu.h
+++ b/programs/winedbg/be_cpu.h
@@ -20,7 +20,7 @@
enum be_cpu_addr {be_cpu_addr_pc, be_cpu_addr_stack, be_cpu_addr_frame};
enum be_xpoint_type {be_xpoint_break, be_xpoint_watch_exec, be_xpoint_watch_read,
- be_xpoint_watch_write};
+ be_xpoint_watch_write, be_xpoint_FAIL=-1};
struct backend_cpu
{
const DWORD machine;
--
2.4.2
More information about the wine-patches
mailing list