msi: Remove comparison of pointer with >= NULL (PVS-Studio)

Michael Stefaniuc mstefani at redhat.de
Mon Mar 9 04:30:56 CDT 2015


---
This is a no-op change as far as gcc is concerned (CFLAGS=-O2 -g0).



 dlls/msi/database.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/msi/database.c b/dlls/msi/database.c
index 940d3d9..dd2c004 100644
--- a/dlls/msi/database.c
+++ b/dlls/msi/database.c
@@ -155,8 +155,7 @@ UINT MSI_OpenDatabaseW(LPCWSTR szDBPath, LPCWSTR szPersist, MSIDATABASE **pdb)
     if( !pdb )
         return ERROR_INVALID_PARAMETER;
 
-    if (szPersist - MSIDBOPEN_PATCHFILE >= MSIDBOPEN_READONLY &&
-        szPersist - MSIDBOPEN_PATCHFILE <= MSIDBOPEN_CREATEDIRECT)
+    if (szPersist - MSIDBOPEN_PATCHFILE <= MSIDBOPEN_CREATEDIRECT)
     {
         TRACE("Database is a patch\n");
         szPersist -= MSIDBOPEN_PATCHFILE;
-- 
1.9.3



More information about the wine-patches mailing list