ws2_32: Avoid using bitwise operations on BOOLs (PVS-Studio)

Michael Stefaniuc mstefani at redhat.de
Tue Mar 10 04:20:02 CDT 2015


---
out_buf works as a BOOL in that case so use BOOL operations.


 dlls/ws2_32/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c
index b4ed865..a9f60cc 100644
--- a/dlls/ws2_32/socket.c
+++ b/dlls/ws2_32/socket.c
@@ -3938,7 +3938,7 @@ INT WINAPI WSAIoctl(SOCKET s, DWORD code, LPVOID in_buff, DWORD in_size, LPVOID
              * because BSD returns TRUE if it's in the OOB mark
              * while Windows returns TRUE if there are NO OOB bytes.
              */
-            (*(WS_u_long *) out_buff) = oob | !atmark;
+            (*(WS_u_long *) out_buff) = oob || !atmark;
         }
 
         release_sock_fd( s, fd );
-- 
1.9.3



More information about the wine-patches mailing list