winecfg: add note about 32 bit prefixes to dialog

Jason Overland jasonoverland at gmail.com
Mon Mar 23 21:08:06 CDT 2015


Hi, this is my first time submitting a patch to Wine.

Context behind this:  To run Simcity 2000 I change my Wine prefix
settings to mimic NT 3.5 so that it uses a different file chooser dialog
which doesn't crash the game (for whatever reason).  This last time
installing things I was confused about why I didn't see the option for
NT 3.5 until slackner reminded me on IRC that I need a 32 bit prefix to
have that option.

So, I thought it might be useful if the dialog could have a note explaining why
those options aren't there if you're running from a 64 bit prefix -- and
thus this patch.  To make room for the text I made the applications
Listbox 20 pixels shorter.

Jason

---
  programs/winecfg/appdefaults.c |  6 +++++-
  programs/winecfg/resource.h    |  1 +
  programs/winecfg/winecfg.rc    | 11 ++++++-----
  3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/programs/winecfg/appdefaults.c b/programs/winecfg/appdefaults.c
index 66085f4..d23438a 100644
--- a/programs/winecfg/appdefaults.c
+++ b/programs/winecfg/appdefaults.c
@@ -239,7 +239,11 @@ static void init_appsheet(HWND dialog)
    }
  
    init_comboboxes(dialog);
-
+
+#ifndef _WIN64
+  ShowWindow(GetDlgItem(dialog, IDC_VERNOTE), SW_HIDE);
+#endif
+
    /* Select the default settings listview item  */
    item.iItem = 0;
    item.iSubItem = 0;
diff --git a/programs/winecfg/resource.h b/programs/winecfg/resource.h
index 3118fb6..b9f1162 100644
--- a/programs/winecfg/resource.h
+++ b/programs/winecfg/resource.h
@@ -55,6 +55,7 @@
  #define IDD_DRIVECFG                    112
  #define IDD_DESKTOP_INTEGRATION         115
  #define IDC_WINVER                      1012
+#define IDC_VERNOTE                     1013
  #define IDC_DESKTOP_WIDTH               1023
  #define IDC_DESKTOP_HEIGHT              1024
  #define IDC_DESKTOP_SIZE                1025
diff --git a/programs/winecfg/winecfg.rc b/programs/winecfg/winecfg.rc
index 6fc1c26..ed81946 100644
--- a/programs/winecfg/winecfg.rc
+++ b/programs/winecfg/winecfg.rc
@@ -152,11 +152,12 @@ BEGIN
      LTEXT           "Wine can mimic different Windows versions for each application. This tab is linked to the Libraries and Graphics tabs to allow you to change system-wide or per-application settings in those tabs as well.",
                      IDC_STATIC,15,15,227,45
      CONTROL         "",IDC_APP_LISTVIEW,"SysListView32",WS_BORDER | WS_TABSTOP | LVS_LIST | LVS_SINGLESEL | LVS_SHOWSELALWAYS,
-                    15,60,230,110
-    PUSHBUTTON	    "&Add application...",IDC_APP_ADDAPP, 15,174,112,14
-    PUSHBUTTON	    "&Remove application",IDC_APP_REMOVEAPP, 133,174,112,14
-    LTEXT           "&Windows Version:",IDC_STATIC,17,196,80,8
-    COMBOBOX        IDC_WINVER,100,194,145,56,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
+                    15,60,230,90
+    PUSHBUTTON	    "&Add application...",IDC_APP_ADDAPP, 15,154,112,14
+    PUSHBUTTON	    "&Remove application",IDC_APP_REMOVEAPP, 133,154,112,14
+    LTEXT           "&Windows Version:",IDC_STATIC,17,176,80,8
+    COMBOBOX        IDC_WINVER,100,174,145,56,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
+    LTEXT           "Note: Older versions of Windows can only be mimiced in a 32-bit Wine Prefix.",IDC_VERNOTE,17,188,225,20
  END
  
  IDD_GRAPHCFG DIALOG  0, 0, 260, 220
-- 
1.9.1



More information about the wine-patches mailing list