cmd.exe: Remove redundant call to SetConsoleMode

Hugh McMaster hugh.mcmaster at outlook.com
Thu May 7 07:36:52 CDT 2015


Wcmd calls SetConsoleMode. This overrides the console mode initially
set by the console renderer in server/console.c.
Wcmd's call is unnecessary, as the console renderer sets the same
console mode used by wcmd.

This change allows easier configuration of wcmd between 'wine cmd'
and 'wineconsole (cmd)'.
---
 programs/cmd/wcmdmain.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c
index bc9b216..36d2ec1 100644
--- a/programs/cmd/wcmdmain.c
+++ b/programs/cmd/wcmdmain.c
@@ -2593,8 +2593,6 @@ int wmain (int argc, WCHAR *argvW[])
       return errorlevel;
   }
 
-  SetConsoleMode(GetStdHandle(STD_INPUT_HANDLE), ENABLE_LINE_INPUT |
-                 ENABLE_ECHO_INPUT | ENABLE_PROCESSED_INPUT);
   SetConsoleTitleW(WCMD_LoadMessage(WCMD_CONSTITLE));
 
   /* Note: cmd.exe /c dir does not get a new color, /k dir does */
-- 
1.9.1




More information about the wine-patches mailing list