[PATCH] mshtml: fixed incorrect NULL ptr check (Coverity)
Marcus Meissner
marcus at jet.franken.de
Wed May 20 14:23:20 CDT 2015
CID 1299035 Dereference before null check
was introduced by incomplete rename in:
commit f26597753a0dd803b88e0e6321dd4a11eb6ad353
Author: Jacek Caban <jacek at codeweavers.com>
Date: Thu May 14 13:25:09 2015 +0200
mshtml: Pass EventTarget to set_event_handler.
---
dlls/mshtml/htmlevent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c
index 897350f..5567e94 100644
--- a/dlls/mshtml/htmlevent.c
+++ b/dlls/mshtml/htmlevent.c
@@ -1401,7 +1401,7 @@ static HRESULT set_event_handler_disp(EventTarget *event_target, HTMLDocumentNod
return S_OK;
data = get_event_target_data(event_target, TRUE);
- if(!event_target)
+ if(!data)
return E_OUTOFMEMORY;
if(!alloc_handler_vector(data, eid, 0))
--
1.8.4.5
More information about the wine-patches
mailing list