[PATCH] rpcrt4: make sure we do not have *data allocated on error (Coverity)

Marcus Meissner marcus at jet.franken.de
Wed May 20 17:10:57 CDT 2015


713688 Resource leak

callers expect *data only allocated when success is returned.

simplified after Michaels comment
---
 dlls/rpcrt4/rpc_transport.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c
index 34f434d..a6438a7 100644
--- a/dlls/rpcrt4/rpc_transport.c
+++ b/dlls/rpcrt4/rpc_transport.c
@@ -2359,6 +2359,7 @@ static RPC_STATUS rpcrt4_http_read_http_packet(HINTERNET request, RpcHttpAsyncDa
     if (!RPCRT4_IsValidHttpPacket(hdr, *data, data_len))
     {
         ERR("invalid http packet\n");
+        HeapFree(GetProcessHeap(), 0, *data);
         return RPC_S_PROTOCOL_ERROR;
     }
 
-- 
1.8.4.5




More information about the wine-patches mailing list