[PATCH] winex11drv: Fix uninitialized memory access appearing in multiple tests (Valgrind) (resend)

Indrek Altpere efbiaiinzinz at hotmail.com
Thu May 28 04:13:41 CDT 2015


Try 2: explicitly zero the remaining fields instead of using memset
Fixes https://bugs.winehq.org/show_bug.cgi?id=38593
---
 dlls/winex11.drv/window.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c
index 06e2294..7146cfc 100644
--- a/dlls/winex11.drv/window.c
+++ b/dlls/winex11.drv/window.c
@@ -725,6 +725,8 @@ static void set_mwm_hints( struct x11drv_win_data *data, DWORD style, DWORD ex_s
            data->hwnd, mwm_hints.decorations, mwm_hints.functions, style, ex_style );
 
     mwm_hints.flags = MWM_HINTS_FUNCTIONS | MWM_HINTS_DECORATIONS;
+    mwm_hints.input_mode = 0;
+    mwm_hints.status = 0;
     XChangeProperty( data->display, data->whole_window, x11drv_atom(_MOTIF_WM_HINTS),
                      x11drv_atom(_MOTIF_WM_HINTS), 32, PropModeReplace,
                      (unsigned char*)&mwm_hints, sizeof(mwm_hints)/sizeof(long) );
-- 
1.9.1




More information about the wine-patches mailing list