[PATCH 9/11] qcap: add the SmartTee filter automatically as necessary, and test this

Damjan Jovanovic damjan.jov at gmail.com
Thu May 28 12:11:17 CDT 2015


This patch also deletes some prior
ICaptureGraphBuilder::RenderStream() tests. I've done this because the
tests:
1. Are testing irrelevant details, such as the order in which filter
and pin methods are called in.
2. Vary even between Windows versions, meaning Windows apps probably
don't rely on the tested behaviour as a result.
3. Are extremely difficult to implement correctly, as they impose
operations that must be performed in a certain order but no clear
reason what for. It would far more useful, for example, to test what
arguments are passed to FindPin().

Thank you
Damjan
---
 dlls/qcap/capturegraph.c         | 147 ++++++++++--
 dlls/qcap/tests/qcap.c           | 160 +------------
 dlls/qcap/tests/smartteefilter.c | 504 +++++++++++++++++++++++++++++++++++++--
 3 files changed, 611 insertions(+), 200 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-qcap-add-the-SmartTee-filter-automatically-as-necessar.txt
Type: text/x-patch
Size: 40783 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20150528/b0b3b519/attachment-0001.bin>


More information about the wine-patches mailing list