[PATCH] mshtml: Make it clear that ATTR_FIX_PX and ATTR_FIX_URL as exclusive (Coverity)

Jacek Caban jacek at codeweavers.com
Wed Nov 11 04:07:27 CST 2015


Signed-off-by: Jacek Caban <jacek at codeweavers.com>


On 11/10/15 20:31, Nikolay Sivov wrote:
> Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
> ---
>
> Otherwise first allocated val is leaked. Jacek, can you confirm?

Well, I don't think this causes a real leak because even if we try to
apply both fixups, the attribute would need to be URL and integer at the
same time for the leak to happen. However, I don't think there are
attributes that could require both fixups, so I'm fine with the patch.

Thanks,
Jacek



More information about the wine-patches mailing list