[PATCH] wininet: Remove a bit of dead code (Coverity)

Nikolay Sivov nsivov at codeweavers.com
Sun Nov 22 17:17:18 CST 2015


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---

Previously flags were set back with InternetQueryOptionW and its result was
stored in 'res'. This logic was replaced with direct access to http_request_t.

 dlls/wininet/dialogs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/dlls/wininet/dialogs.c b/dlls/wininet/dialogs.c
index bf4121b..938daa8 100644
--- a/dlls/wininet/dialogs.c
+++ b/dlls/wininet/dialogs.c
@@ -416,8 +416,6 @@ static INT_PTR WINAPI WININET_InvalidCertificateDialog(
     case WM_COMMAND:
         if( wParam == IDOK )
         {
-            BOOL res = TRUE;
-
             if( params->dwFlags & FLAGS_ERROR_UI_FLAGS_CHANGE_OPTIONS )
             {
                 http_request_t *req = params->req;
@@ -456,7 +454,7 @@ static INT_PTR WINAPI WININET_InvalidCertificateDialog(
                     req->netconn->security_flags |= flags;
             }
 
-            EndDialog( hdlg, res ? ERROR_SUCCESS : ERROR_NOT_SUPPORTED );
+            EndDialog( hdlg, ERROR_SUCCESS );
             return TRUE;
         }
         if( wParam == IDCANCEL )
-- 
2.6.2




More information about the wine-patches mailing list