wine-development: FTBFS on hurd-i386
Andrew Eikum
aeikum at codeweavers.com
Mon Nov 23 08:05:46 CST 2015
Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
Looks OK to me, but the subject obviously needs to change.
"winepulse.drv: Avoid PATH_MAX in Windows code" or something.
Andrew
On Sat, Nov 21, 2015 at 05:47:05PM +0100, Svante Signell wrote:
> Signed-off by: svante.signell at gmail.com
>
> Hello,
>
> Submitting this patch directly to wine-patches on request from Jens
> Ryer.
>
> BTW: There are still some parts of the code using PATH_MAX, but does
> not seem to be triggered with the debian builds. Is it of interest to
> remove also the remaining entries?
>
> Thanks!
>
> On Fri, 2015-11-20 at 20:12 +0100, Svante Signell wrote:
> > Source: wine-development
> > Version: 1.7.55-3
> > Severity: important
> > Tags: patch
> > Usertags: hurd
> > User: debian-hurd at lists.debian.org
> >
> > Hello,
> >
> > Up till 1.7.55-2 wine-development built fine due to the recent
> > upstream
> > PATH_MAX fixes. Unfortunately, with the enabling of libpulse, the
> > PATH_MAX problem arises again. The attached patch use the internally
> > used MAX_PATH number, as for other parts of the code. With this patch
> > the latest version builds OK too.
> >
> > Please forward this upstream, since they are in a code freeze for
> > wine-1.8.
> >
> > Thanks!
> Index: wine-development-1.7.55/dlls/winepulse.drv/mmdevdrv.c
> ===================================================================
> --- wine-development-1.7.55.orig/dlls/winepulse.drv/mmdevdrv.c
> +++ wine-development-1.7.55/dlls/winepulse.drv/mmdevdrv.c
> @@ -440,7 +440,7 @@ static void pulse_probe_settings(int ren
> static HRESULT pulse_connect(void)
> {
> int len;
> - WCHAR path[PATH_MAX], *name;
> + WCHAR path[MAX_PATH], *name;
> char *str;
>
> if (!pulse_thread)
> @@ -519,7 +519,7 @@ static void pulse_phys_speakers_cb(pa_co
> static HRESULT pulse_test_connect(void)
> {
> int len, ret;
> - WCHAR path[PATH_MAX], *name;
> + WCHAR path[MAX_PATH], *name;
> char *str;
> pa_operation *o;
>
>
More information about the wine-patches
mailing list