ieframe: Use BOOL instead of VARIANT_BOOL in on_commandstate_change().

Jacek Caban jacek at codeweavers.com
Wed Nov 25 05:03:53 CST 2015


On 11/25/15 10:04, Michael Stefaniuc wrote:
> Commit abe564ad3bed8eee07dda6032bc926f63fe2960b started this change:
> - "enable" is treated like a BOOL now.
> - It is passed to methods that take a BOOL as an argument.

Yes, the plan was to change it to BOOL, but it seems to have forgot to
finish that. Thanks for taking care of that.
> Signed-off-by: Michael Stefaniuc <mstefani at redhat.de>
> ---
>
> De facto this is a no-op but the compiler generates different code for
> dochost.c. So I'm fine if this patch gets Deferred. I just want to
> send it now as long as my memory is fresh. I got puzzled by two false
> positive defects reported by PVS-Studio in lines that were later
> modified by the above commit.

I think it's fine to commit it now.

Signed-off-by: Jacek Caban <jacek at codeweavers.com>





More information about the wine-patches mailing list