msacm32/tests: Remove always true condition (PVS-Studio)

Michael Stefaniuc mstefani at redhat.de
Tue Oct 13 16:58:37 CDT 2015


dd.szShortName is an array of CHAR and not an arbitrary pointer.

Signed-off-by: Michael Stefaniuc <mstefani at redhat.de>
---
 dlls/msacm32/tests/msacm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msacm32/tests/msacm.c b/dlls/msacm32/tests/msacm.c
index 0defb33..4c9dca0 100644
--- a/dlls/msacm32/tests/msacm.c
+++ b/dlls/msacm32/tests/msacm.c
@@ -145,7 +145,7 @@ static BOOL CALLBACK DriverEnumProc(HACMDRIVERID hadid,
             "acmDriverDetailsA(): cbStruct = %08x\n", dd.cbStruct);
 
         for (iter = expected_ids; iter->shortname; ++iter) {
-            if (dd.szShortName && !strcmp(iter->shortname, dd.szShortName)) {
+            if (!strcmp(iter->shortname, dd.szShortName)) {
                 /* try alternative product id on mismatch */
                 if (iter->pid_alt && iter->pid != dd.wPid)
                     ok(iter->mid == dd.wMid && iter->pid_alt == dd.wPid,
-- 
2.1.0



More information about the wine-patches mailing list