[Tools] testbot: Don't sleep after a revert.
Francois Gouget
fgouget at codeweavers.com
Wed Oct 21 07:21:21 CDT 2015
It may be needed for hypervisors that start the VM before fully
reloading its state but that's the exception.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
testbot/lib/WineTestBot/Config.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
VMware is one such hypervisor and it could cause the VM to be slower /
stall while it's getting paged in which could have a detrimental effect
on the tests. So there it makes sense to wait a bit for VMware to finish
getting the VM ready (though it would make more sense to disale that
VMware feature). But with QEmu we don't have this issue so it's just
wasted time which I have confirmed testing this locally.
So I propose applying this patch and restarting the Engine. Should
things go wrong it's easy to change back.
diff --git a/testbot/lib/WineTestBot/Config.pm b/testbot/lib/WineTestBot/Config.pm
index db7f18d..cb5bfe4 100644
--- a/testbot/lib/WineTestBot/Config.pm
+++ b/testbot/lib/WineTestBot/Config.pm
@@ -66,7 +66,7 @@ $MaxRevertingVMs = 1;
$MaxRevertsWhileRunningVMs = 1;
$MaxActiveVMs = 2;
$MaxVMsWhenIdle = undef;
-$SleepAfterRevert = 30;
+$SleepAfterRevert = 0;
$WaitForToolsInVM = 30;
$SuiteTimeout = 30 * 60;
--
2.6.1
More information about the wine-patches
mailing list