[PATCH] ntdll/tests: Skip RtlRandom tests on Windows 10.

Austin English austinenglish at gmail.com
Mon Sep 14 12:28:23 CDT 2015


On Mon, Sep 14, 2015 at 12:24 PM, Lauri Kenttä <lauri.kentta at gmail.com> wrote:
> Windows 10 uses a different algorithm for RtlRandom.
> All the tests currently fail and produce tons of spam.
> (There's already a similar case for Windows Vista.)
> ---
>  dlls/ntdll/tests/rtl.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/dlls/ntdll/tests/rtl.c b/dlls/ntdll/tests/rtl.c
> index 9a4ec48..f42e313 100644
> --- a/dlls/ntdll/tests/rtl.c
> +++ b/dlls/ntdll/tests/rtl.c
> @@ -739,6 +739,16 @@ static void test_RtlRandom(void)
>          return;
>      }
>
> +/*
> + * Windows 10 uses different algorithms, so skip the rest of the tests
> + * until that is figured out. Trace output for the failures is about 23 MB!
> + */
> +
> +    if (seed == 0x7fffffc3) {
> +        skip("Most likely running on Windows 10 which uses a different algorithm\n");
> +        return;
> +    }
> +
>      ok(result == result_expected,
>          "pRtlRandom(&seed (seed == 0)) returns %x, expected %x\n",
>          result, result_expected);
> --
> 2.5.1

This should probably be win_skip() rather than skip().

-- 
-Austin



More information about the wine-patches mailing list