[PATCH] winhlp32: fix some images not shown in certain 16-bit help files
Jean-Christophe Cardot
wine at cardot.net
Fri Apr 15 05:08:03 CDT 2016
Fixes https://bugs.winehq.org/show_bug.cgi?id=23768
Subfiles with bitmap images are usually prefixed with '|', but sometimes not.
Unfortunately, there is no consensus among different pieces of unofficial
documentation. So remove leading '|' and try again.
Signed-off-by: Jean-Christophe Cardot <wine at cardot.net>
---
programs/winhlp32/hlpfile.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/programs/winhlp32/hlpfile.c b/programs/winhlp32/hlpfile.c
index 1102b10..b32daa8 100644
--- a/programs/winhlp32/hlpfile.c
+++ b/programs/winhlp32/hlpfile.c
@@ -507,6 +507,18 @@ static BOOL HLPFILE_FindSubFile(HLPFILE* hlpfile, LPCSTR name, BYTE **subbuf, BY
WINE_TRACE("looking for file '%s'\n", name);
ptr = HLPFILE_BPTreeSearch(hlpfile->file_buffer + GET_UINT(hlpfile->file_buffer, 4),
name, comp_FindSubFile);
+ if (!ptr)
+ { /* Subfiles with bitmap images are usually prefixed with '|', but sometimes not.
+ Unfortunately, there is no consensus among different pieces of unofficial
+ documentation. So remove leading '|' and try again. */
+ CHAR c = *name++;
+ if (c == '|')
+ {
+ WINE_TRACE("not found. try '%s'\n", name);
+ ptr = HLPFILE_BPTreeSearch(hlpfile->file_buffer + GET_UINT(hlpfile->file_buffer, 4),
+ name, comp_FindSubFile);
+ }
+ }
if (!ptr) return FALSE;
*subbuf = hlpfile->file_buffer + GET_UINT(ptr, strlen(name)+1);
if (*subbuf >= hlpfile->file_buffer + hlpfile->file_buffer_size)
--
2.7.4
More information about the wine-patches
mailing list