[PATCH] d3dx9: Don't complain when overwriting effect object id 0.
Matteo Bruni
mbruni at codeweavers.com
Sun Apr 17 12:15:17 CDT 2016
Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
---
dlls/d3dx9_36/effect.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
index 8c3560c..9f227df 100644
--- a/dlls/d3dx9_36/effect.c
+++ b/dlls/d3dx9_36/effect.c
@@ -4812,10 +4812,17 @@ static HRESULT d3dx9_parse_name(char **name, const char *ptr)
return D3D_OK;
}
-static HRESULT d3dx9_copy_data(struct d3dx_object *object, const char **ptr)
+static HRESULT d3dx9_copy_data(struct d3dx9_base_effect *base, unsigned int object_id, const char **ptr)
{
+ struct d3dx_object *object = &base->objects[object_id];
+
if (object->size || object->data)
- FIXME("Object already initialized!\n");
+ {
+ if (object_id)
+ FIXME("Overwriting object id %u!\n", object_id);
+ else
+ TRACE("Overwriting object id 0.\n");
+ }
read_dword(ptr, &object->size);
TRACE("Data size: %#x\n", object->size);
@@ -5618,7 +5625,7 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char *
case D3DXPT_VERTEXSHADER:
case D3DXPT_PIXELSHADER:
state->type = ST_CONSTANT;
- if (FAILED(hr = d3dx9_copy_data(&base->objects[param->object_id], ptr)))
+ if (FAILED(hr = d3dx9_copy_data(base, param->object_id, ptr)))
return hr;
if (object->data)
@@ -5634,7 +5641,7 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char *
case D3DXPT_FLOAT:
case D3DXPT_STRING:
state->type = ST_FXLC;
- if (FAILED(hr = d3dx9_copy_data(&base->objects[param->object_id], ptr)))
+ if (FAILED(hr = d3dx9_copy_data(base, param->object_id, ptr)))
return hr;
d3dx_create_param_eval(base, object->data, object->size, param->type, ¶m->param_eval);
break;
@@ -5647,7 +5654,7 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char *
case 1:
state->type = ST_PARAMETER;
- if (FAILED(hr = d3dx9_copy_data(&base->objects[param->object_id], ptr)))
+ if (FAILED(hr = d3dx9_copy_data(base, param->object_id, ptr)))
return hr;
TRACE("Looking for parameter %s.\n", debugstr_a(object->data));
@@ -5675,7 +5682,7 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char *
case 2:
state->type = ST_ARRAY_SELECTOR;
- if (FAILED(hr = d3dx9_copy_data(object, ptr)))
+ if (FAILED(hr = d3dx9_copy_data(base, param->object_id, ptr)))
return hr;
hr = d3dx9_parse_array_selector(base, param);
break;
@@ -5775,7 +5782,7 @@ static HRESULT d3dx9_parse_effect(struct d3dx9_base_effect *base, const char *da
read_dword(&ptr, &id);
TRACE("Id: %u\n", id);
- if (FAILED(hr = d3dx9_copy_data(&base->objects[id], &ptr)))
+ if (FAILED(hr = d3dx9_copy_data(base, id, &ptr)))
goto err_out;
if (base->objects[id].data)
--
2.7.3
More information about the wine-patches
mailing list