[PATCH 5/5] qedit: Implement IAMTimelineObj_GetTimelineNoRef and add tests.

Alex Henrie alexhenrie24 at gmail.com
Mon Apr 25 22:10:00 CDT 2016


Cc: Andrew Eikum <aeikum at codeweavers.com>

Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
 dlls/qedit/tests/timeline.c | 6 ++++++
 dlls/qedit/timelineobj.c    | 6 ++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/dlls/qedit/tests/timeline.c b/dlls/qedit/tests/timeline.c
index 3f4f1d7..cd4033d 100644
--- a/dlls/qedit/tests/timeline.c
+++ b/dlls/qedit/tests/timeline.c
@@ -74,6 +74,12 @@ static void test_timeline(void)
         else
             ok(hr == E_INVALIDARG, "Expected E_INVALIDARG got %08x\n", hr);
     }
+
+    hr = IAMTimelineObj_GetTimelineNoRef(obj, NULL);
+    ok(hr == E_POINTER, "Expected E_POINTER got %08x\n", hr);
+
+    hr = IAMTimelineObj_GetTimelineNoRef(obj, &timeline);
+    ok(hr == E_NOINTERFACE, "Expected E_NOINTERFACE got %08x\n", hr);
 }
 
 START_TEST(timeline)
diff --git a/dlls/qedit/timelineobj.c b/dlls/qedit/timelineobj.c
index e96d920..a91d6e8 100644
--- a/dlls/qedit/timelineobj.c
+++ b/dlls/qedit/timelineobj.c
@@ -375,9 +375,11 @@ static HRESULT WINAPI TimelineObj_RemoveAll(IAMTimelineObj *iface)
 
 static HRESULT WINAPI TimelineObj_GetTimelineNoRef(IAMTimelineObj *iface, IAMTimeline **timeline)
 {
+    /* MSDN says that this function is "not supported" */
     TimelineObjImpl *This = impl_from_IAMTimelineObj(iface);
-    FIXME("(%p)->(%p): not implemented!\n", This, timeline);
-    return E_NOTIMPL;
+    TRACE("(%p)->(%p)\n", This, timeline);
+    if (!timeline) return E_POINTER;
+    return E_NOINTERFACE;
 }
 
 static HRESULT WINAPI TimelineObj_GetGroupIBelongTo(IAMTimelineObj *iface, IAMTimelineGroup **group)
-- 
2.8.0




More information about the wine-patches mailing list