[PATCH] dwrite: Add missing return value check (Coverity)

Nikolay Sivov nsivov at codeweavers.com
Thu Aug 4 02:56:38 CDT 2016


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
 dlls/dwrite/font.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c
index d1a04db..d354eaf 100644
--- a/dlls/dwrite/font.c
+++ b/dlls/dwrite/font.c
@@ -1596,12 +1596,13 @@ static HRESULT WINAPI dwritefont3_GetFontFaceReference(IDWriteFont3 *iface, IDWr
 static BOOL WINAPI dwritefont3_HasCharacter(IDWriteFont3 *iface, UINT32 ch)
 {
     struct dwrite_font *This = impl_from_IDWriteFont3(iface);
+    HRESULT hr;
     BOOL ret;
 
     TRACE("(%p)->(0x%x)\n", This, ch);
 
-    IDWriteFont_HasCharacter((IDWriteFont*)iface, ch, &ret);
-    return ret;
+    hr = IDWriteFont_HasCharacter((IDWriteFont*)iface, ch, &ret);
+    return hr == S_OK && ret;
 }
 
 static DWRITE_LOCALITY WINAPI dwritefont3_GetLocality(IDWriteFont3 *iface)
-- 
2.8.1




More information about the wine-patches mailing list