[PATCH] xmllite: hr was uninitialized in error path (Coverity)

Marcus Meissner marcus at jet.franken.de
Sat Dec 17 05:37:10 CST 2016


CID 1397005 Uninitialized scalar variable

Signed-off-by: Marcus Meissner <marcus at jet.franken.de>
---
 dlls/xmllite/reader.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c
index 0fedd91d1a..460eeab06e 100644
--- a/dlls/xmllite/reader.c
+++ b/dlls/xmllite/reader.c
@@ -547,8 +547,10 @@ static HRESULT reader_push_element(xmlreader *reader, strval *prefix, strval *lo
     }
 
     element = reader_alloc_zero(reader, sizeof(*element));
-    if (!element)
+    if (!element) {
+        hr = E_OUTOFMEMORY;
         goto failed;
+    }
 
     if ((hr = reader_strvaldup(reader, prefix, &element->prefix)) != S_OK ||
             (hr = reader_strvaldup(reader, localname, &element->localname)) != S_OK ||
-- 
2.11.0




More information about the wine-patches mailing list