[PATCH] ntdll: cast left shifted 1 to be ulong wide (Coverity)

Marcus Meissner marcus at jet.franken.de
Sat Feb 6 08:30:59 CST 2016


CID 1351885:    (BAD_SHIFT)

Signed-off-by: Marcus Meissner <marcus at jet.franken.de>
---
 dlls/ntdll/nt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/ntdll/nt.c b/dlls/ntdll/nt.c
index 9b750e4..5c8b7fd 100644
--- a/dlls/ntdll/nt.c
+++ b/dlls/ntdll/nt.c
@@ -1520,7 +1520,7 @@ static NTSTATUS create_logical_proc_info(SYSTEM_LOGICAL_PROCESSOR_INFORMATION **
                 fclose(f);
             }
             else r = 0;
-            if(!logical_proc_info_add_by_id(data, dataex, &len, max_len, RelationProcessorPackage, r, 1 << i))
+            if(!logical_proc_info_add_by_id(data, dataex, &len, max_len, RelationProcessorPackage, r, (ULONG_PTR)1 << i))
             {
                 fclose(fcpu_list);
                 return STATUS_NO_MEMORY;
@@ -1534,7 +1534,7 @@ static NTSTATUS create_logical_proc_info(SYSTEM_LOGICAL_PROCESSOR_INFORMATION **
                 fclose(f);
             }
             else r = i;
-            if(!logical_proc_info_add_by_id(data, dataex, &len, max_len, RelationProcessorCore, r, 1 << i))
+            if(!logical_proc_info_add_by_id(data, dataex, &len, max_len, RelationProcessorCore, r, (ULONG_PTR)1 << i))
             {
                 fclose(fcpu_list);
                 return STATUS_NO_MEMORY;
-- 
2.7.0




More information about the wine-patches mailing list