[PATCH 1/2] dsound: Avoid NULL pointer dereference (Coverity).

Andrew Eikum aeikum at codeweavers.com
Wed Feb 10 11:22:22 CST 2016


---

CID 215542

Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
---
 dlls/dsound/buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/dsound/buffer.c b/dlls/dsound/buffer.c
index 2a80c3f..e85a5d1 100644
--- a/dlls/dsound/buffer.c
+++ b/dlls/dsound/buffer.c
@@ -1205,9 +1205,9 @@ HRESULT IDirectSoundBufferImpl_Duplicate(
         HeapFree(GetProcessHeap(),0,dsb->pwfx);
         HeapFree(GetProcessHeap(),0,dsb);
         dsb = NULL;
-    }
+    }else
+        IDirectSoundBuffer8_AddRef(&dsb->IDirectSoundBuffer8_iface);
 
-    IDirectSoundBuffer8_AddRef(&dsb->IDirectSoundBuffer8_iface);
     *ppdsb = dsb;
     return hres;
 }
-- 
2.7.1





More information about the wine-patches mailing list