[PATCH] comctl32/trackbar: Update thumb immediately on key press (try 2)

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Mon Jan 18 02:43:57 CST 2016


From: Nikolay Sivov <nsivov at codeweavers.com>

Changed the key press to use VK_END, since moving one value may not
change the thumb position on screen.

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
---
 dlls/comctl32/tests/trackbar.c | 9 ++++++++-
 dlls/comctl32/trackbar.c       | 2 +-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/dlls/comctl32/tests/trackbar.c b/dlls/comctl32/tests/trackbar.c
index 7c04d15..adb1b12 100644
--- a/dlls/comctl32/tests/trackbar.c
+++ b/dlls/comctl32/tests/trackbar.c
@@ -672,7 +672,14 @@ static void test_position(void)
     r = SendMessageA(hWndTrackbar, TBM_GETPOS, 0, 0);
     ok(r == 30, "got %d\n", r);
     SendMessageA(hWndTrackbar, TBM_GETTHUMBRECT, 0, (LPARAM)&rect2);
-    ok(rect.left != rect2.left, "got %d\n", rect.left);
+    ok(rect.left != rect2.left, "got %d, expected %d\n", rect2.left, rect.left);
+
+    /* now move it with keys */
+    SendMessageA(hWndTrackbar, WM_KEYDOWN, VK_END, 0);
+    r = SendMessageA(hWndTrackbar, TBM_GETPOS, 0, 0);
+    ok(r == 100, "got %d\n", r);
+    SendMessageA(hWndTrackbar, TBM_GETTHUMBRECT, 0, (LPARAM)&rect);
+    ok(rect.left != rect2.left, "got %d, expected %d\n", rect.left, rect2.left);
 
     DestroyWindow(hWndTrackbar);
 }
diff --git a/dlls/comctl32/trackbar.c b/dlls/comctl32/trackbar.c
index c0f58db..87d955c 100644
--- a/dlls/comctl32/trackbar.c
+++ b/dlls/comctl32/trackbar.c
@@ -1821,7 +1821,7 @@ TRACKBAR_KeyDown (TRACKBAR_INFO *infoPtr, INT nVirtKey)
     }
 
     if (pos != infoPtr->lPos) {
-	infoPtr->flags |=TB_THUMBPOSCHANGED;
+	TRACKBAR_UpdateThumb (infoPtr);
 	TRACKBAR_InvalidateThumbMove (infoPtr, pos, infoPtr->lPos);
     }
 
-- 
2.7.0.rc3




More information about the wine-patches mailing list