[PATCH 6/6] amstream: Implement AMAudioData::SetFormat.

Anton Baskanov baskanov at gmail.com
Wed Jul 27 07:51:53 CDT 2016


Signed-off-by: Anton Baskanov <baskanov at gmail.com>
---
 dlls/amstream/audiodata.c       | 18 +++++++++--
 dlls/amstream/tests/audiodata.c | 70 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 86 insertions(+), 2 deletions(-)

diff --git a/dlls/amstream/audiodata.c b/dlls/amstream/audiodata.c
index 1c729fc..06ed932 100644
--- a/dlls/amstream/audiodata.c
+++ b/dlls/amstream/audiodata.c
@@ -185,9 +185,23 @@ static HRESULT WINAPI IAudioDataImpl_GetFormat(IAudioData* iface, WAVEFORMATEX *
 
 static HRESULT WINAPI IAudioDataImpl_SetFormat(IAudioData* iface, const WAVEFORMATEX *wave_format)
 {
-    FIXME("(%p)->(%p): stub\n", iface, wave_format);
+    AMAudioDataImpl *This = impl_from_IAudioData(iface);
+
+    TRACE("(%p)->(%p)\n", iface, wave_format);
+
+    if (!wave_format)
+    {
+        return E_POINTER;
+    }
 
-    return E_NOTIMPL;
+    if (WAVE_FORMAT_PCM != wave_format->wFormatTag)
+    {
+        return E_INVALIDARG;
+    }
+
+    This->wave_format = *wave_format;
+
+    return S_OK;
 }
 
 static const struct IAudioDataVtbl AudioData_Vtbl =
diff --git a/dlls/amstream/tests/audiodata.c b/dlls/amstream/tests/audiodata.c
index b2aa385..a14f100 100755
--- a/dlls/amstream/tests/audiodata.c
+++ b/dlls/amstream/tests/audiodata.c
@@ -22,6 +22,10 @@
 
 #include "wine/test.h"
 #include "amstream.h"
+#include "mmreg.h"
+#include "initguid.h"
+#include "ks.h"
+#include "ksmedia.h"
 
 static IUnknown *create_audio_data(void)
 {
@@ -218,6 +222,71 @@ out_unknown:
     IUnknown_Release(unknown);
 }
 
+static void test_set_format(void)
+{
+    IUnknown *unknown = create_audio_data();
+    IAudioData *audio_data = NULL;
+    WAVEFORMATPCMEX wave_format = {{0}};
+
+    HRESULT result = S_OK;
+
+    result = IUnknown_QueryInterface(unknown, &IID_IAudioData, (void **)&audio_data);
+    if (FAILED(result))
+    {
+        /* test_query_interface handles this case */
+        skip("No IAudioData\n");
+        goto out_unknown;
+    }
+
+    result = IAudioData_SetFormat(audio_data, NULL);
+    ok(E_POINTER == result, "got 0x%08x\n", result);
+
+    wave_format.Format.wFormatTag = WAVE_FORMAT_EXTENSIBLE;
+    wave_format.Format.nChannels = 2;
+    wave_format.Format.nSamplesPerSec = 44100;
+    wave_format.Format.nAvgBytesPerSec = 176400;
+    wave_format.Format.nBlockAlign = 4;
+    wave_format.Format.wBitsPerSample = 16;
+    wave_format.Format.cbSize = 22;
+    wave_format.Samples.wValidBitsPerSample = 16;
+    wave_format.dwChannelMask = KSAUDIO_SPEAKER_STEREO;
+    wave_format.SubFormat = KSDATAFORMAT_SUBTYPE_PCM;
+    result = IAudioData_SetFormat(audio_data, &wave_format.Format);
+    ok(E_INVALIDARG == result, "got 0x%08x\n", result);
+
+    wave_format.Format.wFormatTag = WAVE_FORMAT_PCM;
+    wave_format.Format.nChannels = 2;
+    wave_format.Format.nSamplesPerSec = 44100;
+    wave_format.Format.nAvgBytesPerSec = 176400;
+    wave_format.Format.nBlockAlign = 4;
+    wave_format.Format.wBitsPerSample = 16;
+    wave_format.Format.cbSize = 0;
+    result = IAudioData_SetFormat(audio_data, &wave_format.Format);
+    ok(S_OK == result, "got 0x%08x\n", result);
+
+    wave_format.Format.wFormatTag = 0xdead;
+    wave_format.Format.nChannels = 0xdead;
+    wave_format.Format.nSamplesPerSec = 0xdeadbeef;
+    wave_format.Format.nAvgBytesPerSec = 0xdeadbeef;
+    wave_format.Format.nBlockAlign = 0xdead;
+    wave_format.Format.wBitsPerSample = 0xdead;
+    wave_format.Format.cbSize = 0xdead;
+    result = IAudioData_GetFormat(audio_data, &wave_format.Format);
+    ok(S_OK == result, "got 0x%08x\n", result);
+    ok(WAVE_FORMAT_PCM == wave_format.Format.wFormatTag, "got %u\n", wave_format.Format.wFormatTag);
+    ok(2 == wave_format.Format.nChannels, "got %u\n", wave_format.Format.nChannels);
+    ok(44100 == wave_format.Format.nSamplesPerSec, "got %u\n", wave_format.Format.nSamplesPerSec);
+    ok(176400 == wave_format.Format.nAvgBytesPerSec, "got %u\n", wave_format.Format.nAvgBytesPerSec);
+    ok(4 == wave_format.Format.nBlockAlign, "got %u\n", wave_format.Format.nBlockAlign);
+    ok(16 == wave_format.Format.wBitsPerSample, "got %u\n", wave_format.Format.wBitsPerSample);
+    ok(0 == wave_format.Format.cbSize, "got %u\n", wave_format.Format.cbSize);
+
+    IAudioData_Release(audio_data);
+
+out_unknown:
+    IUnknown_Release(unknown);
+}
+
 START_TEST(audiodata)
 {
     CoInitialize(NULL);
@@ -227,6 +296,7 @@ START_TEST(audiodata)
     test_set_buffer();
     test_set_actual();
     test_get_format();
+    test_set_format();
 
     CoUninitialize();
 }
-- 
1.9.1




More information about the wine-patches mailing list