[PATCH] dsound: Remove redundant null pointer check (Coverity)

Andrew Eikum aeikum at codeweavers.com
Mon Jun 6 07:47:54 CDT 2016


Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>

On Mon, Jun 06, 2016 at 11:14:38AM +0300, Nikolay Sivov wrote:
> IAudioClient instance could be expected to be valid at this point.
> 
> Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
> ---
>  dlls/dsound/primary.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/dlls/dsound/primary.c b/dlls/dsound/primary.c
> index b14bff7..830764a 100644
> --- a/dlls/dsound/primary.c
> +++ b/dlls/dsound/primary.c
> @@ -387,8 +387,7 @@ err:
>          IAudioStreamVolume_Release(volume);
>      if (render)
>          IAudioRenderClient_Release(render);
> -    if (client)
> -        IAudioClient_Release(client);
> +    IAudioClient_Release(client);
>      HeapFree(GetProcessHeap(), 0, wfx);
>      return hres;
>  }
> -- 
> 2.8.1
> 
> 
> 



More information about the wine-patches mailing list