[PATCH] programs/notepad: Make sure to use large enough buffer when composing window title (Coverity)

Nikolay Sivov nsivov at codeweavers.com
Mon Mar 7 13:04:25 CST 2016


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
 programs/notepad/dialog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/programs/notepad/dialog.c b/programs/notepad/dialog.c
index 1ea2ef9..94301b8 100644
--- a/programs/notepad/dialog.c
+++ b/programs/notepad/dialog.c
@@ -101,9 +101,9 @@ VOID ShowLastError(void)
  */
 void UpdateWindowCaption(void)
 {
-  WCHAR szCaption[MAX_STRING_LEN];
-  WCHAR szNotepad[MAX_STRING_LEN];
   static const WCHAR hyphenW[] = { ' ','-',' ',0 };
+  WCHAR szNotepad[64];
+  WCHAR szCaption[ARRAY_SIZE(Globals.szFileTitle) + ARRAY_SIZE(hyphenW) + ARRAY_SIZE(szNotepad)];
 
   if (Globals.szFileTitle[0] != '\0')
       lstrcpyW(szCaption, Globals.szFileTitle);
-- 
2.7.0




More information about the wine-patches mailing list