[PATCH] ieframe/tests: Fix BSTR leak (Valgrind)

Nikolay Sivov nsivov at codeweavers.com
Thu Nov 10 02:22:34 CST 2016


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---

It returns S_FALSE for zero length BSTR

 dlls/ieframe/tests/webbrowser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ieframe/tests/webbrowser.c b/dlls/ieframe/tests/webbrowser.c
index 763e0b9..ca2a131 100644
--- a/dlls/ieframe/tests/webbrowser.c
+++ b/dlls/ieframe/tests/webbrowser.c
@@ -260,7 +260,7 @@ static void _test_LocationURL(unsigned line, IWebBrowser2 *wb, const char *exurl
 
     hres = IWebBrowser2_get_LocationURL(wb, &url);
     ok_(__FILE__,line) (hres == (*exurl ? S_OK : S_FALSE), "get_LocationURL failed: %08x\n", hres);
-    if (hres == S_OK)
+    if (SUCCEEDED(hres))
     {
         ok_(__FILE__,line) (!strcmp_wa(url, exurl), "unexpected URL: %s\n", wine_dbgstr_w(url));
         SysFreeString(url);
-- 
2.10.2




More information about the wine-patches mailing list