[PATCH] ieframe: Fix moniker leak on error path

Nikolay Sivov nsivov at codeweavers.com
Thu Nov 10 05:47:10 CST 2016


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
 dlls/ieframe/navigate.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/dlls/ieframe/navigate.c b/dlls/ieframe/navigate.c
index 296ed19..658857f 100644
--- a/dlls/ieframe/navigate.c
+++ b/dlls/ieframe/navigate.c
@@ -703,13 +703,16 @@ static HRESULT bind_to_object(DocHost *This, IMoniker *mon, LPCWSTR url, IBindCt
     hres = IMoniker_GetDisplayName(mon, 0, NULL, &display_name);
     if(FAILED(hres)) {
         FIXME("GetDisplayName failed: %08x\n", hres);
+        IMoniker_Release(mon);
         return hres;
     }
 
     hres = set_dochost_url(This, display_name);
     CoTaskMemFree(display_name);
-    if(FAILED(hres))
+    if(FAILED(hres)) {
+        IMoniker_Release(mon);
         return hres;
+    }
 
     IBindCtx_RegisterObjectParam(bindctx, (LPOLESTR)SZ_HTML_CLIENTSITE_OBJECTPARAM,
                                  (IUnknown*)&This->IOleClientSite_iface);
-- 
2.10.2




More information about the wine-patches mailing list